Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual repos #109

Merged
merged 2 commits into from
May 10, 2019
Merged

Virtual repos #109

merged 2 commits into from
May 10, 2019

Conversation

jniesen
Copy link

@jniesen jniesen commented Apr 4, 2019

Description

Adds back the ability to set repositories when creating a virtual repo. This feature existed in a previous version of the code (#58), but was lost at some point.

Related Issue

#108

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@jniesen jniesen requested a review from a team as a code owner April 4, 2019 18:45
@tduffield
Copy link
Contributor

Thanks for the PR @jniesen. I'll see if I can find someone more familiar with the codebase to take a look at this for you.

@jaymalasinha jaymalasinha requested a review from tas50 April 9, 2019 13:59
@jniesen
Copy link
Author

jniesen commented Apr 18, 2019

Hey @tduffield @jaymalasinha or @tas50, I just wanted to check in on this.

@schisamo schisamo merged commit 10763ae into chef:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants