Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version string comparison for Minitar and uncomment install feature #32

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

tpowell-progress
Copy link
Collaborator

@tpowell-progress tpowell-progress commented Aug 14, 2024

Description

Problem

❯ bundle update --conservative berkshelf
Warning: the running version of Bundler (2.2.33) is older than the version that created the lockfile (2.3.26). We suggest you to upgrade to the version that created the lockfile by running `gem install bundler:2.3.26`.
Fetching https://github.com/chef/berkshelf.git

[!] There was an error while loading `berkshelf.gemspec`: comparison of Gem::Version with String failed. Bundler cannot continue.

 #  from /Users/powell/.rbenv/versions/3.0.6/lib/ruby/gems/3.0.0/bundler/gems/berkshelf-cb35db3c8ac9/berkshelf.gemspec:42
 #  -------------------------------------------
 #
 >    if ruby_version >= "3.1"
 #      s.add_dependency "minitar",              "~> 1.0"

After pointing at this fix:

Using knife 17.10.162 from source at `../knife` and installing its executables
Using kitchen-inspec 2.5.2
Using berkshelf 8.0.12 (was 8.0.9) from https://github.com/chef/berkshelf.git (at tp/ruby-version-berkshelf@4400ffa)
Bundle updated!
Post-install message from minitar:
The `minitar` executable is no longer bundled with `minitar`. If you are
expecting this executable, make sure you also install `minitar-cli`.

Check List

  • New functionality includes tests
  • All tests pass
  • RELEASE_NOTES.md has been updated if required (not required for bugfixes, required for API changes)

Signed-off-by: Thomas Powell <thomas.powell@progress.com>
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
Copy link

@johnmccrae johnmccrae merged commit 7bdff08 into main Aug 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants