Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation changes for apt_package resource #4156

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Add documentation changes for apt_package resource #4156

merged 4 commits into from
Jan 31, 2024

Conversation

neha-p6
Copy link
Contributor

@neha-p6 neha-p6 commented Aug 14, 2023 •
edited
Loading

Description

Add documentation updates about newly added property anchor_package_regex to apt_package.

Definition of Done

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussion that's relevant]

Related PRs

chef/chef#13873

Check List

  • Spell Check
  • Local build
  • Examine the local build
  • All tests pass

@neha-p6 neha-p6 requested a review from a team as a code owner August 14, 2023 09:52
@netlify
Copy link

netlify bot commented Aug 14, 2023 •
edited
Loading

✅ Deploy Preview for chef-web-docs ready!

Name Link
🔨 Latest commit 5930eb5
🔍 Latest deploy log https://app.netlify.com/sites/chef-web-docs/deploys/65ba573fbce3cd0009819214
😎 Deploy Preview https://deploy-preview-4156--chef-web-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@neha-p6 neha-p6 mentioned this pull request Aug 25, 2023
Merged
10 tasks
@neha-p6 neha-p6 force-pushed the neha-p6/CHEF-5629_apt_package branch 2 times, most recently from f8687a0 to 16ebcb2 Compare August 25, 2023 13:53
@neha-p6 neha-p6 force-pushed the neha-p6/CHEF-5629_apt_package branch 2 times, most recently from cd2a931 to cffbfa1 Compare August 29, 2023 08:26
@IanMadd
Copy link
Contributor

IanMadd commented Aug 29, 2023

Related PR: chef/chef#13873

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@neha-p6 neha-p6 mentioned this pull request Oct 6, 2023
Merged
10 tasks
tpowell-progress
tpowell-progress reviewed Oct 26, 2023
View reviewed changes
data/infra/resources/apt_package.yaml

```ruby
apt_package 'lua5.3' do
version '5.3.3-1.1ubuntu2'
Copy link

@tpowell-progress tpowell-progress Oct 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IanMadd any idea how to turn the [vale] error on this off? This isn't even a range

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we can just skip it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@neha-p6
Copy link
Contributor Author

neha-p6 commented Oct 27, 2023

NOTE: Corresponding Infra Client feature chef/chef#13873 is not released yet (merged but not released). So this PR needs to be merged after next Infra Client 18.x.x release

@neha-p6 neha-p6 force-pushed the neha-p6/CHEF-5629_apt_package branch 2 times, most recently from 81e3b27 to 2a01488 Compare December 8, 2023 18:05
neha-p6 and others added 2 commits December 9, 2023 09:28
@neha-p6
Add documentation changes for apt_package resource
2830465 
Update property description

Signed-off-by: Neha Pansare <neha.pansare@progress.com>
@IanMadd @neha-p6
Update data/infra/resources/apt_package.yaml
a8d3afd 
Signed-off-by: Neha Pansare <neha.pansare@progress.com>
@neha-p6 neha-p6 force-pushed the neha-p6/CHEF-5629_apt_package branch from 2a01488 to a8d3afd Compare December 9, 2023 03:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IanMadd IanMadd mentioned this pull request Jan 25, 2024
Merged
4 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@IanMadd IanMadd merged commit 5fd761f into main Jan 31, 2024
11 of 13 checks passed
@IanMadd IanMadd deleted the neha-p6/CHEF-5629_apt_package branch January 31, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpowell-progress tpowell-progress tpowell-progress left review comments

@IanMadd IanMadd IanMadd approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neha-p6 @IanMadd @tpowell-progress