Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[update] Updating authorization manifest README.md and Runtime README.md files #1865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[update] Updating authorization manifest README.md and Runtime README.md files #1865

wants to merge 2 commits into from

Conversation

mhatrevi
Copy link
Collaborator

@mhatrevi mhatrevi commented Dec 21, 2024 •
edited
Loading

No description provided.

@mhatrevi mhatrevi force-pushed the vmhatre/update-auth-man-doc branch from 3614d01 to cbcbfba Compare December 21, 2024 00:37
swenson
swenson previously approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jhand2
jhand2 reviewed Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@jhand2 jhand2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly just have structural comments

runtime/README.md Outdated Show resolved Hide resolved
runtime/README.md Outdated Show resolved Hide resolved
runtime/README.md Show resolved Hide resolved
runtime/README.md Show resolved Hide resolved
@mhatrevi mhatrevi changed the title [update] Updating authorization manifest README.md and Runtime README… [update] Updating authorization manifest README.md and Runtime README.md files Jan 2, 2025
@nquarton nquarton mentioned this pull request Jan 8, 2025
Open
12 tasks
jlmahowa-amd
jlmahowa-amd reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jlmahowa-amd jlmahowa-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there instructions on how to use the auth-manifest app to generate the manifest?

auth-manifest/README.md Outdated Show resolved Hide resolved
runtime/README.md Outdated Show resolved Hide resolved
@mhatrevi mhatrevi force-pushed the vmhatre/update-auth-man-doc branch from 8f5c243 to 7f535d6 Compare January 22, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhand2 jhand2 jhand2 left review comments

@jlmahowa-amd jlmahowa-amd jlmahowa-amd approved these changes

@swenson swenson swenson left review comments

@fdamato fdamato Awaiting requested review from fdamato fdamato is a code owner

@rusty1968 rusty1968 Awaiting requested review from rusty1968 rusty1968 is a code owner

@bluegate010 bluegate010 Awaiting requested review from bluegate010 bluegate010 is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Caliptra v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhatrevi @swenson @jhand2 @jlmahowa-amd