Merge pull request #2341 from hzeller/feature-20250121-stray-absl-str…

…ingview Fix stray absl string_view dependency.
chipsalliance · Jan 21, 2025 · 931a691 · 931a691
2 parents e90ef18 + 4c74243
commit 931a691
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.github/bin/check-potential-problems.sh b/.github/bin/check-potential-problems.sh
@@ -21,8 +21,15 @@ EXIT_CODE=0
 
 # absl has a string_view but there is also std::string_view.
 # Use the std::string_view throughout.
-find verible -name "*.h" -o -name "*.cc" | \
-  xargs grep -n "absl::string_view"
+find verible -name "*.h" -o -name "*.cc" | xargs grep -n "absl::string_view"
+if [ $? -eq 0 ]; then
+  echo "::error:: use std::string_view instead of absl::string_view"
+  echo
+  EXIT_CODE=1
+fi
+
+# ... same for absl string_view dependency.
+find verible -name BUILD | xargs grep -n absl/strings:string_view
 if [ $? -eq 0 ]; then
   echo "::error:: use std::string_view instead of absl::string_view"
   echo

diff --git a/verible/common/util/BUILD b/verible/common/util/BUILD
@@ -665,7 +665,6 @@ cc_library(
     hdrs = ["simple-zip.h"],
     deps = [
         "//third_party/portable_endian",
-        "@abseil-cpp//absl/strings:string_view",
         "@zlib",
     ],
 )