refactor: cleanup console.log statements in server

chrisbenincasa · Nov 8, 2024 · c89616a · c89616a
1 parent 86c5330
commit c89616a
Show file tree

Hide file tree

Showing 13 changed files with 40 additions and 70 deletions.
diff --git a/server/src/api/channelsApi.ts b/server/src/api/channelsApi.ts
@@ -349,8 +349,6 @@ export const channelsApi: RouterPluginAsyncCallback = async (fastify) => {
         req.body,
       );
 
-      console.log('hello');
-
       if (isNil(result)) {
         return res.status(500).send();
       }
@@ -378,8 +376,6 @@ export const channelsApi: RouterPluginAsyncCallback = async (fastify) => {
         () => req.serverCtx.channelDB.loadCondensedLineup(req.params.id),
       );
 
-      console.log('hello');
-
       if (isNil(newLineup)) {
         return res.status(500).send();
       }

diff --git a/server/src/api/debugApi.ts b/server/src/api/debugApi.ts
@@ -255,9 +255,7 @@ export const debugApi: RouterPluginAsyncCallback = async (fastify) => {
       const result = await new LineupCreator().resolveLineup(
         req.query.channelId,
       );
-      ifDefined(result, (r) => {
-        console.log(r.lineup.items.length);
-      });
+      ifDefined(result, (r) => {});
       return res.send(result);
     },
   );

diff --git a/server/src/api/fillerListsApi.ts b/server/src/api/fillerListsApi.ts
@@ -124,8 +124,6 @@ export const fillerListsApi: RouterPluginAsyncCallback = async (fastify) => {
         return res.status(404).send();
       }
 
-      console.log('sending response');
-
       return res.send({
         id: result.uuid,
         name: result.name,

diff --git a/server/src/cli/legacyMigrateCommand.ts b/server/src/cli/legacyMigrateCommand.ts
@@ -22,40 +22,41 @@ const MigratableEntities = [
   'cached-images',
 ];
 
-export const LegacyMigrateCommand: CommandModule<{}, LegacyMigrateCommandArgs> =
-  {
-    command: 'legacy-migrate',
-    describe: 'Migrate from the legacy .dizquetv database',
-    builder: {
-      legacy_path: {
-        type: 'string',
-        default: path.join(process.cwd(), '.dizquetv'),
-        coerce(arg: string) {
-          if (!existsSync(arg)) {
-            throw new Error(`No directory found at ${arg}`);
-          }
-          return arg;
-        },
-      },
-      entities: {
-        type: 'array',
-        choices: MigratableEntities,
-        coerce(arg) {
-          if (isArray(arg)) {
-            return arg as string[];
-          } else if (isString(arg)) {
-            return arg.split(',');
-          } else {
-            throw new Error('Bad arg');
-          }
-        },
+export const LegacyMigrateCommand: CommandModule<
+  object,
+  LegacyMigrateCommandArgs
+> = {
+  command: 'legacy-migrate',
+  describe: 'Migrate from the legacy .dizquetv database',
+  builder: {
+    legacy_path: {
+      type: 'string',
+      default: path.join(process.cwd(), '.dizquetv'),
+      coerce(arg: string) {
+        if (!existsSync(arg)) {
+          throw new Error(`No directory found at ${arg}`);
+        }
+        return arg;
       },
     },
-    handler: async (argv) => {
-      console.log('Migrating DB from legacy schema...');
-      return await new LegacyDbMigrator(
-        getSettings(),
-        argv.legacy_path,
-      ).migrateFromLegacyDb(argv.entities);
+    entities: {
+      type: 'array',
+      choices: MigratableEntities,
+      coerce(arg) {
+        if (isArray(arg)) {
+          return arg as string[];
+        } else if (isString(arg)) {
+          return arg.split(',');
+        } else {
+          throw new Error('Bad arg');
+        }
+      },
     },
-  };
+  },
+  handler: async (argv) => {
+    return await new LegacyDbMigrator(
+      getSettings(),
+      argv.legacy_path,
+    ).migrateFromLegacyDb(argv.entities);
+  },
+};
diff --git a/server/src/cli/settings/settingsUpdateCommand.ts b/server/src/cli/settings/settingsUpdateCommand.ts
@@ -39,10 +39,6 @@ export const SettingsUpdateCommand: CommandModule<
       await getSettings().directUpdate((prev) => {
         prev.settings = validSettings;
       });
-
-      console.log(
-        JSON.stringify(validSettings, undefined, args.pretty ? 4 : undefined),
-      );
     } catch (e) {
       console.error(e);
     }

diff --git a/server/src/cli/settings/settingsViewCommand.ts b/server/src/cli/settings/settingsViewCommand.ts
@@ -37,9 +37,5 @@ export const SettingsViewCommand: CommandModule<
     if (isArray(viewSettings) && !isEmpty(viewSettings)) {
       viewSettings = viewSettings[0];
     }
-
-    console.log(
-      JSON.stringify(viewSettings, null, args.pretty ? 4 : undefined),
-    );
   },
 };
diff --git a/server/src/dao/channelDb.ts b/server/src/dao/channelDb.ts
@@ -630,7 +630,6 @@ export class ChannelDB {
       return await directDbAccess()
         .transaction()
         .execute(async (tx) => {
-          console.log('in here');
           await tx
             .updateTable('channel')
             .where('channel.uuid', '=', id)
@@ -677,7 +676,7 @@ export class ChannelDB {
               ops,
               ({ operation }) => operation === 'add',
             );
-            console.log(adds, removes);
+
             if (!isEmpty(removes)) {
               await tx
                 .deleteFrom('channelPrograms')

diff --git a/server/src/dao/migrations/lineups/SlotShowIdMigration.ts b/server/src/dao/migrations/lineups/SlotShowIdMigration.ts
@@ -22,7 +22,7 @@ export class SlotShowIdMigration extends ChannelLineupMigration<0, 1> {
       switch (slot.programming.type) {
         case 'show':
           await this.handleSlot(slot.programming);
-          console.log(slot.programming);
+
           break;
         default:
           continue;

diff --git a/server/src/server.ts b/server/src/server.ts
@@ -414,7 +414,6 @@ export async function initServer(opts: ServerOptions) {
           schedule.gracefulShutdown(),
           new Promise<boolean>((resolve) => {
             setTimeout(() => {
-              console.log('here!');
               resolve(false);
             }, 1000);
           }).then(() => {

diff --git a/server/src/services/dynamic_channels/ScheduledRedirectOperator.ts b/server/src/services/dynamic_channels/ScheduledRedirectOperator.ts
@@ -32,7 +32,7 @@ export class ScheduledRedirectOperator extends SchedulingOperator<ScheduledRedir
 
     let t0 = channelStart;
     while (t0 < end) {
-      // console.log(newItems, newOffsets);
+      //
       // Find out how far into the channel we are. This is measured in days essentially
       const since = dayjs.duration(t0.diff(channelStart));
       // Then find how far into the day the redirect would start
@@ -47,7 +47,7 @@ export class ScheduledRedirectOperator extends SchedulingOperator<ScheduledRedir
       );
 
       if (!isNull(idx)) {
-        // console.log(idx);
+        //
         const programStart = channelStart.add(newOffsets[idx]);
         const untilRedirect = dayjs.duration(redirectStart.diff(programStart));
 
@@ -94,14 +94,6 @@ export class ScheduledRedirectOperator extends SchedulingOperator<ScheduledRedir
           : t0.add(1, 'day');
     }
 
-    // initial(newOffsets)?.forEach((offset, i) =>
-    //   console.log(
-    //     newItems[i].type,
-    //     dayjs(channel.startTime).add(offset).format(),
-    //     i,
-    //   ),
-    // );
-
     return Promise.resolve({
       channel,
       lineup: {

diff --git a/server/src/services/health_checks/FfmpegVersionHealthCheck.ts b/server/src/services/health_checks/FfmpegVersionHealthCheck.ts
@@ -23,8 +23,6 @@ export class FfmpegVersionHealthCheck implements HealthCheck {
     const ffmpegExists = await fileExists(settings.ffmpegExecutablePath);
     const ffprobeExists = await fileExists(settings.ffprobeExecutablePath);
 
-    console.log(ffmpegExists, ffprobeExists);
-
     const warningResult = match([ffmpegExists, ffprobeExists] as const)
       .with([false, true], () =>
         healthCheckResult({
@@ -71,7 +69,6 @@ export class FfmpegVersionHealthCheck implements HealthCheck {
   private isVersionValid(version: FfmpegVersionResult, app: string) {
     const versionString = version.versionString;
 
-    console.log(version);
     // Try to use the parsed major/minor versions first
     if (!isNil(version.majorVersion) && !isNil(version.minorVersion)) {
       const result = match([version.majorVersion, version.minorVersion])

diff --git a/server/src/util/logging/basicPrettyTransport.ts b/server/src/util/logging/basicPrettyTransport.ts
@@ -2,7 +2,6 @@ import { once } from 'events';
 import { createWriteStream } from 'fs';
 
 export default async (options) => {
-  console.log(options);
   const stream = createWriteStream('test.log');
   await once(stream, 'open');
   return stream;

diff --git a/server/src/util/runWorker.ts b/server/src/util/runWorker.ts
@@ -12,7 +12,6 @@ export function runWorker<T>(
 ): Promise<T> {
   return queue.add<T>(
     async () => {
-      console.log(filenameWithoutExtension);
       const worker =
         process.env.NODE_ENV !== 'production'
           ? new Worker(new URL(import.meta.resolve('tsx/cli')), {