Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): add more Rust log configs #25

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

brennenputh
Copy link
Contributor

This PR adds extra Rust log statements, particularly for debug logs. I went to write my Rust and realized a bunch of these were missing!

Checklist

  • Used only camelCase variable names.
  • If functionality is added or modified, also made respective changes to the
    README.md (the .txt file is auto-generated and does not need to be modified).

@brennenputh brennenputh changed the title Add rust configs for all relevant log types feat(rust): Add more Rust log configs Jan 4, 2025
@brennenputh brennenputh changed the title feat(rust): Add more Rust log configs feat(rust): add more Rust log configs Jan 4, 2025
@chrisgrieser
Copy link
Owner

Time log is missing the marker and the index (the later is needed to differentiate multiple time logs). Also, stylua complains about some missing talking commas.

Otherwise looking good!

@brennenputh
Copy link
Contributor Author

Should be resolved now, thanks for looking close!

@chrisgrieser chrisgrieser merged commit 4104d5b into chrisgrieser:main Jan 4, 2025
3 checks passed
@chrisgrieser
Copy link
Owner

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants