Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inital move to @emotion/styled #48

Closed
wants to merge 11 commits into from
Closed

Inital move to @emotion/styled #48

wants to merge 11 commits into from

Conversation

PhilGarb
Copy link
Contributor

@PhilGarb PhilGarb commented Oct 6, 2020

Hi @chrisjpatty I have moved the css classes into emotion styled components. I thought before I comment in #18 I submit a PR and we can discuss changes here. It would be great if you would have a look on the code and the example to verify, that it is still looking properly. I have not changed any styles or classes. What I have noticed:

  • My prettier plugin has added semicolons here and there and turned ' into ". I could change that again, but it would probably be best to include a .prettierrc to enforce a code style across PR's. Only if you are interested in using prettier of course.
  • The Connection Component in Connection.js cannot be easily refactored I have left a comment about it in the file.

@PhilGarb PhilGarb closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant