Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: vpnQosMap definition support #13

Merged
merged 2 commits into from
Dec 10, 2024
Merged

dev: vpnQosMap definition support #13

merged 2 commits into from
Dec 10, 2024

Conversation

sbasan
Copy link
Collaborator

@sbasan sbasan commented Dec 10, 2024

Pull Request summary:

add: vpnQosMap definition support
fix: vpnQosMap type discriminator literal in policy assembly
bump dev version

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@sbasan sbasan force-pushed the sbasan/vpn-qos-map branch from 48a0147 to b9106ed Compare December 10, 2024 11:49
@sbasan sbasan force-pushed the sbasan/vpn-qos-map branch from b9106ed to de12792 Compare December 10, 2024 12:03
@sbasan sbasan requested a review from jpkrajewski December 10, 2024 12:06
@sbasan sbasan marked this pull request as ready for review December 10, 2024 12:06
jpkrajewski
jpkrajewski approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@jpkrajewski jpkrajewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbasan sbasan merged commit cbf08de into dev Dec 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrajewski jpkrajewski jpkrajewski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbasan @jpkrajewski