Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Fix ethernet serialization #6

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

jpkrajewski
Copy link
Collaborator

@jpkrajewski jpkrajewski commented Nov 21, 2024

Pull Request summary:

  • fix fields serialization
  • fix multiple mypy validation errors

Description of changes:

Fix type in field serialization and validation

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@jpkrajewski jpkrajewski requested a review from sbasan November 21, 2024 18:48
@jpkrajewski jpkrajewski self-assigned this Nov 21, 2024
@jpkrajewski jpkrajewski force-pushed the fix-ethernet-serialization branch from 2685bae to 96f74d2 Compare November 21, 2024 18:52
@sbasan sbasan force-pushed the fix-ethernet-serialization branch 6 times, most recently from 26c53d0 to a953f97 Compare November 22, 2024 12:45
@sbasan sbasan force-pushed the fix-ethernet-serialization branch from a953f97 to 5d3a0af Compare November 22, 2024 12:53
@jpkrajewski jpkrajewski merged commit bbbe623 into dev Nov 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants