Merge pull request #829 from cisco-open/fix/update

Fix/update

catalystwan/api/feature_profile_api.py

@@ -909,19 +909,18 @@ def get_parcel(
     def update_parcel(
         self,
         profile_id: UUID,
-        parcel_type: Type[AnyServiceParcel],
-        parcel_id: UUID,
         payload: AnyServiceParcel,
+        parcel_id: UUID,
         vpn_uuid: Optional[UUID] = None,
     ) -> ParcelCreationResponse:
         """
         Update Service Parcel for selected profile_id based on payload type
         """
         if vpn_uuid is not None:
             return self.endpoint.update_lan_vpn_sub_parcel(
-                profile_id, vpn_uuid, removeprefix(parcel_type._get_parcel_type(), "lan/vpn/"), parcel_id, payload
+                profile_id, vpn_uuid, removeprefix(payload._get_parcel_type(), "lan/vpn/"), parcel_id, payload
             )
-        return self.endpoint.update(profile_id, parcel_type._get_parcel_type(), parcel_id, payload)
+        return self.endpoint.update(profile_id, payload._get_parcel_type(), parcel_id, payload)
 
 
 class SystemFeatureProfileAPI:
@@ -1869,7 +1868,7 @@ def create_parcel(self, profile_id: UUID, config: ConfigParcel) -> ParcelCreatio
         """
         return self.endpoint.create(profile_id, config)
 
-    def update_parcel(self, profile_id: UUID, parcel_id: UUID, config: ConfigParcel) -> ParcelCreationResponse:
+    def update_parcel(self, profile_id: UUID, config: ConfigParcel, parcel_id: UUID) -> ParcelCreationResponse:
         """
         Update CLI Parcel for selected profile_id
         """

catalystwan/integration_tests/feature_profile/sdwan/test_service.py

@@ -147,7 +147,7 @@ def test_update(self):
 
         dhcp_server_parcel.address_pool.network_address = Global[IPv4Address](value=IPv4Address("10.3.2.1"))
         dhcp_server_parcel.address_pool.subnet_mask = Global[SubnetMask](value="248.0.0.0")
-        parcel_id = self.api.update_parcel(self.profile_uuid, LanVpnDhcpServerParcel, parcel_id, dhcp_server_parcel).id
+        parcel_id = self.api.update_parcel(self.profile_uuid, dhcp_server_parcel, parcel_id).id
         parcel = self.api.get_parcel(self.profile_uuid, LanVpnDhcpServerParcel, parcel_id)
         assert isinstance(parcel.payload, LanVpnDhcpServerParcel)
         assert parcel.payload == dhcp_server_parcel

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "catalystwan"
-version = "0.35.4dev2"
+version = "0.35.4dev3"
 description = "Cisco Catalyst WAN SDK for Python"
 authors = ["kagorski <kagorski@cisco.com>"]
 readme = "README.md"