This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
dev: support device config items for 20.13 #841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrajewski
reviewed
Oct 27, 2024
def preview_policy_definition_by_id(self, id: UUID) -> PolicyDefinitionPreview: | ||
... | ||
|
||
def save_policy_definition_in_bulk(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intended to leave some route handling?
- save_policy_definition_in_bulk,
- edit_multiple_policy_definition,
- save_policy_definition_in_bulk
- ect..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, these are common method found in apidocs for all /template/policy/definition/...
Never implemented/tested in SDK though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary:
Support device config items for 20.13
Description of changes:
/v1/feature-profile/sdwan/cli/full-config
/v1/feature-profile/sdwan/uc-voice/dsp-farm
/v1/feature-profile/sdwan/uc-voice/media-profile
/v1/feature-profile/sdwan/uc-voice/trunk-group
/template/policy/list/faxprotocol
/template/policy/list/mediaprofile
/template/policy/list/modempassthrough
/template/policy/list/supervisorydisc
/template/policy/list/translationprofile
/template/policy/list/translationrules
/template/policy/list/trunkgroup
/template/policy/definition/dialpeer
/template/policy/definition/fxsport
/template/policy/definition/fxoport
/template/policy/definition/fxsdidport
/template/policy/definition/priisdnport
/template/policy/definition/srstphoneprofile
/template/policy/voice
Usage example:
Checklist: