Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation in Angular guide about peer dependencies #14549

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Documentation in Angular guide about peer dependencies #14549

merged 3 commits into from
Jul 10, 2023

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Jul 10, 2023

Suggested merge commit message (convention)

Docs: Added documentation in Angular guide that ckeditor5-angular package requires peer dependencies. See ckeditor/ckeditor5-angular#376.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@psmyrek psmyrek mentioned this pull request Jul 10, 2023
Merged
pomek
pomek approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit 11bc551 into stable Jul 10, 2023
@pomek pomek deleted the ckeditor5-angular/376 branch July 10, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomek pomek pomek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psmyrek @pomek