Move all icons to the @ckeditor/ckeditor5-icons package
#17750
Conversation
filipsobol
changed the title
@ckeditor/ckeditor5-icons package
There was a problem hiding this comment.
I found a few places with old paths to icons:
-
In
docs/framework/contributing/code-style.md:import BoldIcon from '@ckeditor/ckeditor5-core/theme/icons/bold.svg'; -
In
docs/tutorials/supporting-multiple-versions.md:import TableRowIcon from '@ckeditor/ckeditor5-table/theme/icons/table-row.svg'; -
In
docs/examples/custom/bottom-toolbar-editor.md:import fontColorIcon from '@ckeditor/ckeditor5-font/theme/icons/font-color.svg';
In the docs/updating/update-to-40.md guide, paths to icons have been also changed in the sections describing old updates (to v40.1.0 and to v40.2.0). The new ckeditor5-icons package does not exist there yet.
Also, in the following files I found the webpack config test: /ckeditor5-[^/\\]+[/\\]theme[/\\]icons[/\\][^/\\]+\.svg$/ that probably needs to be aligned with new changes:
docs/getting-started/advanced/integrating-from-source-webpack.mddocs/getting-started/legacy-getting-started/integrations/react.mddocs/getting-started/legacy-getting-started/integrations/vuejs-v2.mddocs/getting-started/legacy-getting-started/integrations/vuejs-v3.mddocs/getting-started/legacy-getting-started/quick-start-other.mddocs/updating/nim-migration/migration-to-new-installation-methods.md
|
I updated all docs except |
| } from 'ckeditor5'; | ||
| import { EasyImage } from 'ckeditor5-premium-features'; | ||
| import fontColorIcon from '@ckeditor/ckeditor5-font/theme/icons/font-color.svg'; | ||
|
|
||
| const fontColorIcon =/* #__PURE__ */ registerIcon( 'fontColor', IconFontColor ); |
There was a problem hiding this comment.
registerIcon() is not available here yet.
| @@ -93,7 +93,7 @@ module.exports = { | |||
| module: { | |||
| rules: [ | |||
| { | |||
| test: /ckeditor5-[^/\\]+[/\\]theme[/\\]icons[/\\][^/\\]+\.svg$/, | |||
| test: /ckeditor5-icons\/theme\/icons\/[^/\\]+\.svg$/, | |||
There was a problem hiding this comment.
It looks like there are more problems with this regexp than expected 🥹
Previous regexp with [^/\\] is invalid - unescaped / delimiter.
Current regexp also contains the same invalid [^/\\] fragment.
Also, for some reasons we were defining these regexps with both \ and / path separators. Not sure if we can just support unix-style / now.
There was a problem hiding this comment.
Previous regexp with
[^/\\]is invalid - unescaped/delimiter.
Not true, sorry. My mistake, because when testing this regexp I chose PCRE2, not JS flavor. The regexp fragment [^/\\] is valid in JS.
So question is only whether we want to use only unix-style / path separator.
| @@ -170,7 +170,7 @@ module.exports = { | |||
| use: [ 'ts-loader' ] | |||
| }, | |||
| { | |||
| test: /ckeditor5-[^/\\]+[/\\]theme[/\\]icons[/\\][^/\\]+\.svg$/, | |||
| test: /cckeditor5-icons\/theme\/icons\/[^/\\]+\.svg$/, | |||
Suggested merge commit message (convention)
Feature: Move all icons to the
@ckeditor/ckeditor5-iconspackage. Related to #16546.Feature: Add
@ckeditor/ckeditor5-iconspackage to the core DLL package.MINOR BREAKING CHANGE: Move all icons to the
@ckeditor/ckeditor5-iconspackage.MINOR BREAKING CHANGE (icons): Rename all icon file names to
kebab-case.Rename the following files:
arrow-down.svgtochevron-down.svg(used inrevision-history, to avoid conflict with the file of the same name frompagination).arrow-up.svgtochevron-up.svg(used inrevision-history, to avoid conflict with the file of the same name frompagination).bookmark_inline.svgtobookmark-inline.svgbulletedlist.svgtobulleted-list.svgcodeblock.svgtocode-block.svgcontentunlock.svgtocontent-unlock.svgexportpdf.svgtoexport-pdf.svgexportword.svgtoexport-word.svghorizontalline.svgtohorizontal-line.svgimportexport.svgtoimport-export.svgimportword.svgtoimport-word.svgliststylecircle.svgtolist-style-circle.svgliststyledecimalleadingzero.svgtolist-style-decimal-leading-zero.svgliststyledecimal.svgtolist-style-decimal.svgliststyledisc.svgtolist-style-disc.svgliststylelowerlatin.svgtolist-style-lower-latin.svgliststylelowerroman.svgtolist-style-lower-roman.svgliststylesquare.svgtolist-style-square.svgliststyleupperlatin.svgtolist-style-upper-latin.svgliststyleupperroman.svgtolist-style-upper-roman.svgnumberedlist.svgtonumbered-list.svgpagebreak.svgtopage-break.svgspecialcharacters.svgtospecial-characters.svgtodolist.svgtotodo-list.svgAdditional information
Follow-up issue: #17755