This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
DB simplification #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 238
💛 - Coveralls |
The function was previously used to check test results for Patchwork2 instances but it's not used anymore. Remove it, together with its tests. Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
Data are inserted into the table, only to never be read. Results are supposed to be reported to Patchwork and emails so there's no need to keep the table. We still save tested patches to check for last tested patch, but we don't need associated data. Removal of the table allows us to simplify commit_patchtest method (renamed to commit_tested) and delete it's test since no data is committed in the method. Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
major
approved these changes
Jun 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#50 contains removal of
get_series_resultfrom Patchwork logic, but since no DB is passed to the function checking it in the first place the pull is good to be separate.This should start the fixes for issue #80