fix: integration_aws-alb: enable all alarms by default

claranet · Jan 10, 2025 · 8ed5c87 · 8ed5c87
1 parent fdf9fdf
commit 8ed5c87
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/modules/integration_aws-alb/conf/03-lb-4xx.yaml b/modules/integration_aws-alb/conf/03-lb-4xx.yaml
@@ -26,7 +26,6 @@ rules:
     lasting_duration: 15m
     lasting_at_least: 0.9
     append_condition: and when(requests > ${var.minimum_traffic})
-    disabled: true
   major:
     threshold: 95
     comparator: ">"

diff --git a/modules/integration_aws-alb/conf/05-target-4xx.yaml b/modules/integration_aws-alb/conf/05-target-4xx.yaml
@@ -26,7 +26,6 @@ rules:
     lasting_duration: 15m
     lasting_at_least: 0.9
     append_condition: and when(requests > ${var.minimum_traffic})
-    disabled: true
   major:
     threshold: 95
     comparator: ">"

diff --git a/modules/integration_aws-alb/variables-gen.tf b/modules/integration_aws-alb/variables-gen.tf
@@ -269,7 +269,7 @@ variable "alb_4xx_disabled" {
 variable "alb_4xx_disabled_critical" {
   description = "Disable critical alerting rule for alb_4xx detector"
   type        = bool
-  default     = true
+  default     = null
 }
 
 variable "alb_4xx_disabled_major" {
@@ -472,7 +472,7 @@ variable "target_4xx_disabled" {
 variable "target_4xx_disabled_critical" {
   description = "Disable critical alerting rule for target_4xx detector"
   type        = bool
-  default     = true
+  default     = null
 }
 
 variable "target_4xx_disabled_major" {