Skip to content

Commit

Permalink
Follow recommended face naming conventions
Browse files Browse the repository at this point in the history
  • Loading branch information
basil-conto committed Sep 27, 2017
1 parent 7189743 commit 87a1fab
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions hackernews.el
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,17 @@

;;; Faces

(defface hackernews-link-face
(defface hackernews-link
'((t :inherit link :foreground "green" :underline nil))
"Face used for links to stories."
:group 'hackernews)

(defface hackernews-comment-count-face
'((t :inherit hackernews-link-face))
(defface hackernews-comment-count
'((t :inherit hackernews-link))
"Face used for comment counts."
:group 'hackernews)

(defface hackernews-score-face
(defface hackernews-score
'((t :inherit default))
"Face used for the score of a story."
:group 'hackernews)
Expand Down Expand Up @@ -193,12 +193,12 @@ not interrupted."

(define-button-type 'hackernews-link
'action #'hackernews-browse-url-action
'face 'hackernews-link-face
'face 'hackernews-link
'follow-link t
'keymap hackernews-button-map)

(define-button-type 'hackernews-comment-count
'face 'hackernews-comment-count-face
'face 'hackernews-comment-count
'supertype 'hackernews-link)

;; Emulate `define-error'
Expand Down Expand Up @@ -344,7 +344,7 @@ their respective URLs."
(format-spec hackernews-item-format
(format-spec-make
?s (propertize (format hackernews-score-format score)
'face 'hackernews-score-face)
'face 'hackernews-score)
?t (hackernews--button-string
'hackernews-link title (or item-url comments-url))
?c (hackernews--button-string
Expand Down

0 comments on commit 87a1fab

Please sign in to comment.