Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total library rewrite #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

arrowcircle
Copy link

Total library rewrite.
Main goals are compatibility with latest Ruby (2.1.2), total architecture remake and old API compatibility.

  1. Extracted and refactored each ruby integration method to separate class.
  2. Rewritten GSL and Ruby wrappers for integrate method.
  3. Rewritten specs to support new syntax. Cleared specs.
  4. Updated Readme to markdown, added instruction for GSL usage (rb-gsl is now runtime dependency)
  5. Added bundler support (Added Gemfile)
  6. Made gem with bundle gem command (for simple rake release)
  7. Added travis-ci

@agarie
Copy link

agarie commented Jun 19, 2014

Hey @clbustos, what do you think? I haven't tested it locally, but these changes seems very good. Ideally, we should send them directly to Sciruby's integration fork.

@arrowcircle thanks for the PR! :)

@clbustos
Copy link
Owner

If doesn't broke any dependent library, fine with me.
El jun 19, 2014 3:00 p.m., "Carlos Agarie" notifications@github.com
escribió:

Hey @clbustos https://github.com/clbustos, what do you think? I haven't
tested it locally, but these changes seems very good. Ideally, we should
send them directly to Sciruby's integration fork
https://github.com/SciRuby/integration.

@arrowcircle https://github.com/arrowcircle thanks for the PR! :)


Reply to this email directly or view it on GitHub
#3 (comment).

@arrowcircle
Copy link
Author

@clbustos, @agarie any updates?

@agarie
Copy link

agarie commented Jul 16, 2014

I finally got some time to read through all the changes.

@clbustos: I think it's good to merge! We should send this to SciRuby/integration (and make it the default repository...) as well.

clbustos pushed a commit that referenced this pull request Aug 9, 2014
@clbustos
Copy link
Owner

clbustos commented Aug 9, 2014

Sorry for the delay. After guys from GSoC 2014 finish, we will rewrite according to your specs.

@arrowcircle
Copy link
Author

Hey, whats going on? GSoC people making small changes, that I already made (bundler, rspec, travis, markdown), but my pull request is hanging for 2 months. Now, my work is useless, because its impossible to merge changes from the master branch. Thanks :(

@clbustos
Copy link
Owner

clbustos commented Aug 9, 2014

Hey, don't we mad. I will check eveything to merge all worth of it.
El ago 9, 2014 9:14 a.m., "Oleg Bovykin" notifications@github.com
escribió:

Hey, whats going on? GSoC people making small changes, that I already made
(bundler, rspec, travis, markdown), but my pull request is hanging for 2
months. Now, my work is useless, because its impossible to merge changes
from the master branch. Thanks :(


Reply to this email directly or view it on GitHub
#3 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants