-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed infile
features
#647
Removed infile
features
#647
Conversation
@lebensterben I am okay with removing these features, but I would prefer not to see all of the code style changes interleaved in the same commit... Did your editor make the style changes automatically? If you would like to make some changes to code style, make a separate commit (with rationale in the commit description if necessary), and make sure that the changes apply to the entire code base. Or you can omit the style changes from this PR if you prefer. |
Yeah. emacs reformatted some files according and reordered imports. |
It's done now. |
The flake8 config is already enforced by Github Actions. You can run the checks locally by running I like the idea of adding a |
@lebensterben It looks like all test files under Otherwise, changes look good to me. |
@phmccarty I removed them ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thanks!
There are multiple issues regarding
infile
support.Notably,
BitBake
.BitBake
's conventions.BitBake
is not well-documented.Since this is never used, I propose to remove this functionality entirely.
#645
#646