Skip to content

Commit

Permalink
workflow fix - prevent premature exit if no modified files are found
Browse files Browse the repository at this point in the history
  • Loading branch information
larrybabb committed Oct 5, 2024
1 parent 27f29b3 commit 46088ef
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ jobs:
id: build_check
run: |
# Get modified files that are in the 'src/' folder and end with '.ts'
MODIFIED_FILES=$(git diff --name-only ${{ github.event.before }} ${{ github.sha }} | grep '^src/.*\.ts$')
MODIFIED_FILES=$(git diff --name-only ${{ github.event.before }} ${{ github.sha }} | grep '^src/.*\.ts$' || true)
# Print the modified files for debugging
echo "Modified files:"
echo "$MODIFIED_FILES"
# Check if the modified_files.txt has any content
# Check if MODIFIED_FILES has any content
if [[ -n "$MODIFIED_FILES" ]]; then
echo "Build should run."
echo "::set-output name=build_ran::true"
Expand Down Expand Up @@ -82,7 +82,7 @@ jobs:
id: get_changed_files
run: |
# Get modified files that are in the 'scripts/' folder and end with '-func.sql' or '-proc.sql'
MODIFIED_FILES=$(git diff --name-only ${{ github.event.before }} ${{ github.sha }} | grep '^scripts/.*\(-func\.sql\| -proc\.sql\)$')
MODIFIED_FILES=$(git diff --name-only ${{ github.event.before }} ${{ github.sha }} | grep '^scripts/.*\(-func\.sql\| -proc\.sql\)$' || true)
# Output the filtered list of modified files
echo "$MODIFIED_FILES" > modified_files.txt
Expand Down
1 change: 0 additions & 1 deletion scripts/gks-procs/variation-identity-proc.sql
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ BEGIN
END as issue,
var.content
FROM var
-- 2,800,531 (4/7/2024)
""", rec.schema_name, rec.schema_name, rec.schema_name, rec.schema_name, rec.schema_name);

EXECUTE IMMEDIATE FORMAT("""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,6 @@ BEGIN

END;



-- select count(*) from `clinvar_ingest.voi_scv_group`;

-- find intersection between voi and voi_scv windows for the same variant to create the voi_group records
Expand Down

0 comments on commit 46088ef

Please sign in to comment.