-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce cider-start-server command #3555
Conversation
by splitting cider-jack-in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Can you confirm that this change does accomplish your end goal?
Co-authored-by: vemv <vemv@users.noreply.github.com>
To a large extend. And then an easy cider connect using host and port I know anyhow (as I fix the port in order to have tunneling working) Something similar could be reached as well by: |
Co-authored-by: vemv <vemv@users.noreply.github.com>
Co-authored-by: vemv <vemv@users.noreply.github.com>
Co-authored-by: vemv <vemv@users.noreply.github.com>
addressing PR comments
from PR review
to cider--start-nrepl-server-with-callback
I think you can also add some keybinding for this in the jack-in keymap and mention in the relevant command menu. |
regrading key binding and &optional
If / when #3563 get decided on and this is merged, we could slightly change the docu again.
|
Thanks! |
Split cider-jack-in in two and therefore obtain interactive function cider-start-server,
which starts the nrpel server without trying to connect afterwards
see here:
https://clojurians.slack.com/archives/C0617A8PQ/p1698268379712609?thread_ts=1698268132.937489&cid=C0617A8PQ
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)eldev lint
) which is based onelisp-lint
and includescheckdoc
, check-declare, packaging metadata, indentation, and trailing whitespace checks.Thanks!
If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.