Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding workers-scale as a separate workload into e2e #736

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Jan 7, 2025

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding workers-scale as separate workload.
Test Plan

Plan is to use it as plugin in the existing jobs and add new jobs for autoscaler cases.
Example PRs in CI:

Captured Test Results

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Tested in CI prow already. Will add functional tests once this PR is merged.

Vishnu Challa added 2 commits December 12, 2024 12:38
Signed-off-by: Vishnu Challa <vchalla@vchalla-thinkpadp1gen2.rmtusnc.csb>
Signed-off-by: Vishnu Challa <vchalla@vchalla-thinkpadp1gen2.rmtusnc.csb>
@openshift-ci openshift-ci bot requested review from morenod and venkataanil January 7, 2025 16:04
Copy link

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vishnuchalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vishnuchalla
Copy link
Collaborator Author

vishnuchalla commented Jan 7, 2025

Once this PR is merged, will work on the schedule and update prow PRs. @krishvoor Will this be a good addition to this ADR as this workload is being plugged into our tests?

@krishvoor
Copy link
Member

Once this PR is merged, will work on the schedule and update prow PRs. @krishvoor Will this be a good addition to this ADR as this workload is being plugged into our tests?

@vishnuchalla Will this be a mainstream test, tested for each release and part of the release readout?
Please add associated information into the ADR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants