Adding the support of Linux bridge interface for VM setup

[capolrik]

Use the --bridge option to create a NAD that will be attached to the VMs

Type of change

• New feature

Description

Adding the support for bridge interface using VMs.
A NNCP needs to be defined before running the test to defined the linux bridge.
Then, the bridge name should be passed to the option:

k8s-netperf --debug --vm --bridge br0

with the following NNCP (nmstate operator required)

apiVersion: nmstate.io/v1alpha1
kind: NodeNetworkConfigurationPolicy
metadata:
  name: br0-eth1
spec:
  desiredState:
    interfaces:
      - name: br0
        description: Linux bridge with eno2 as a port
        type: linux-bridge
        state: up
        ipv4:
          dhcp: true
          enabled: true
        bridge:
          options:
            stp:
              enabled: false
          port:
            - name: eno2

Related Tickets & Documents

• Related Issue: https://issues.redhat.com/browse/PERFSCALE-3605

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.

Testing

On OCP 4.17, 4.18.0.rc

k8s-netperf --debug --vm --bridge br0

and

k8s-netperf --debug --vm

[capolrik]

@jtaleric @rsevilla87 this change has been tested on 4.17 and 4.18 and is stable, it is ready for review.

[jtaleric]

my only concern here is if a user needs to override this -- if they already have a 10.10.10/24 network defined. I am OK with a default, but should we allow the user to override the interface IP in the event they already use a 10net?

[capolrik]

This is a legitimate concern, I have added a little logic to handle this by passing an optional ipv4 network parameter but I don't have a cluster to test this for now. It will wait until next week.