Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for coriolis.diagnostics.api module #302

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

Cristi1324
Copy link
Contributor

@Cristi1324 Cristi1324 commented Mar 29, 2024

This PR adds unit tests for coriolis.diagnostics.api module

@Cristi1324 Cristi1324 changed the title Add tests for coriolis.conductor.diagnostics.api module Add tests for coriolis.diagnostics.api module Mar 29, 2024
@Cristi1324 Cristi1324 force-pushed the diagnostics-unit-tests branch from 764a0af to 0d733ce Compare March 29, 2024 11:56
Copy link
Contributor

@Dany9966 Dany9966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the copyright year, LGTM

@@ -1,7 +1,9 @@
from coriolis import utils
# Copyright 2024 Cloudbase Solutions Srl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put original year of file creation. I checked it using git blame on the file.

Suggested change
# Copyright 2024 Cloudbase Solutions Srl
# Copyright 2019 Cloudbase Solutions Srl

@Cristi1324 Cristi1324 force-pushed the diagnostics-unit-tests branch from 0d733ce to 3d3a3b5 Compare April 17, 2024 11:09
@Dany9966 Dany9966 merged commit 130d690 into cloudbase:master Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants