Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for osmorphing.osmount* #314

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Add unit tests for osmorphing.osmount* #314

merged 5 commits into from
Jun 25, 2024

Conversation

mihaelabalutoiu
Copy link
Contributor

@mihaelabalutoiu mihaelabalutoiu commented Apr 30, 2024 •
edited
Loading

This PR adds unit testing for the following modules:

  • osmorphing.osmount.base.py
  • osmorphing.osmount.factory.py
  • osmorphing.osmount.redhat.py
  • osmorphing.osmount.ubuntu.py
  • osmorphing.osmount.windows.py

@mihaelabalutoiu mihaelabalutoiu changed the title Add unit tests for osmorphing.osmount.base.py Add unit tests for osmorphing.osmount* May 17, 2024
ionutbalutoiu
ionutbalutoiu suggested changes Jun 4, 2024
View reviewed changes
Copy link

@ionutbalutoiu ionutbalutoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few suggestions before this LGTM.

coriolis/tests/osmorphing/osmount/test_factory.py Show resolved Hide resolved
coriolis/tests/osmorphing/osmount/test_factory.py Show resolved Hide resolved
coriolis/tests/osmorphing/osmount/test_redhat.py Show resolved Hide resolved
coriolis/tests/osmorphing/osmount/test_redhat.py Outdated Show resolved Hide resolved
coriolis/tests/osmorphing/osmount/test_ubuntu.py Outdated Show resolved Hide resolved
coriolis/tests/osmorphing/osmount/test_base.py Show resolved Hide resolved
coriolis/tests/osmorphing/osmount/test_base.py Show resolved Hide resolved
coriolis/tests/osmorphing/osmount/test_base.py Show resolved Hide resolved
coriolis/tests/osmorphing/osmount/test_base.py Outdated Show resolved Hide resolved
coriolis/tests/osmorphing/osmount/test_base.py Show resolved Hide resolved
@mihaelabalutoiu
Add unit tests for osmorphing.osmount.base.py
5da1f6a 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for osmorphing.osmount.factory.py
fad72ab 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for osmorphing.osmount.redhat.py
ad66e01 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for osmorphing.osmount.ubuntu.py
ffd5c03 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for osmorphing.osmount.windows.py
b8e9177 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu mihaelabalutoiu force-pushed the add-osmorphing-osmount-unit-tests branch from 6112e1a to b8e9177 Compare June 6, 2024 19:53
mihaelabalutoiu
mihaelabalutoiu commented Jun 6, 2024
View reviewed changes
Copy link
Contributor Author

@mihaelabalutoiu mihaelabalutoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the changes, please take a look now. Thank you a lot!

coriolis/tests/osmorphing/osmount/test_redhat.py Show resolved Hide resolved
coriolis/tests/osmorphing/osmount/test_windows.py Outdated Show resolved Hide resolved
ionutbalutoiu
ionutbalutoiu approved these changes Jun 17, 2024
View reviewed changes
Copy link

@ionutbalutoiu ionutbalutoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dany9966 Dany9966 merged commit 2672285 into cloudbase:master Jun 25, 2024
4 checks passed
@mihaelabalutoiu mihaelabalutoiu deleted the add-osmorphing-osmount-unit-tests branch June 25, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionutbalutoiu ionutbalutoiu ionutbalutoiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihaelabalutoiu @ionutbalutoiu @Dany9966