[notebook] fix notebook saving type

* [notebook] use notebook type instead of the first snippet's type
cloudera · Aug 10, 2023 · abd4ce6 · abd4ce6
1 parent 4bc91b5
commit abd4ce6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/desktop/libs/notebook/src/notebook/api.py b/desktop/libs/notebook/src/notebook/api.py
@@ -475,11 +475,9 @@ def get_logs(request):
 
 def _save_notebook(notebook, user):
   if notebook['snippets'][0].get('connector') and notebook['snippets'][0]['connector'].get('dialect'):  # TODO Connector unification
-    notebook_type = 'query-%(dialect)s' % notebook['snippets'][0]['connector']
     if notebook['snippets'][0] and notebook['snippets'][0].get('executor'):
       notebook['snippets'][0]['executor']['executables'] = []
-  else:
-    notebook_type = notebook.get('type', 'notebook')
+  notebook_type = notebook.get('type', 'notebook')
 
   save_as = False
 

diff --git a/desktop/libs/notebook/src/notebook/api_tests.py b/desktop/libs/notebook/src/notebook/api_tests.py
@@ -176,7 +176,7 @@ def test_save_notebook_with_connector_off(self):
 
     assert_equal(0, data['status'], data)
     doc = Document2.objects.get(pk=data['id'])
-    assert_equal('query-mysql', doc.type)
+    assert_equal('query-hive', doc.type)
 
 
   def test_save_notebook_with_connector_on(self):
@@ -206,7 +206,7 @@ def test_save_notebook_with_connector_on(self):
 
     assert_equal(0, data['status'], data)
     doc = Document2.objects.get(pk=data['id'])
-    assert_equal('query-mysql', doc.type)
+    assert_equal('query-hive', doc.type)
 
 
   def test_historify(self):