handle non numeric id for namespace #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default placeholder namespace_id is non numeric and breaks when we attempt to load record from db. This is actually an invalid id and we should not really be attempting to load from db. Change-Id: If5305457291e779804434dd93f9dcf2e075fb903
amitsrivastava
force-pushed
the
dev/amit/fix_query_lookup_by_id
branch
from
32ad217 to
a5732e3
Compare
Harshg999
approved these changes
Oct 27, 2023
wing2fly
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the default placeholder namespace_id is non numeric and breaks when we attempt to load record from db. This is actually an invalid id and we should not really be attempting to load from db.
Change-Id: If5305457291e779804434dd93f9dcf2e075fb903