[ui-storagebrowser] adds available space check in chunk upload #3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JohanAhlen
reviewed
Jan 6, 2025
| const uploadItem = async (item: UploadItem) => { | ||
| const isSpaceAvailable = await checkAvailableSpace(item.file.size); | ||
| if (!isSpaceAvailable) { | ||
| onStatusUpdate(item, FileUploadStatus.Failed); |
There was a problem hiding this comment.
What is the message to the user in this case?
There was a problem hiding this comment.
For now, it will show the failed status. Need to figure out how can we show the reason being "insufficient space"!
I can show the reason on hovering the error icon, can talk to our Designer for the same.
nidhibhatg
approved these changes
Jan 7, 2025
JohanAhlen
approved these changes
Jan 10, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?