Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui-storagebrowser] Adds silent polling for list_dir during file upload #3951

Merged
merged 3 commits into from
Jan 14, 2025
Merged

[ui-storagebrowser] Adds silent polling for list_dir during file upload #3951

merged 3 commits into from
Jan 14, 2025

Conversation

ramprasadagarwal
Copy link
Collaborator

@ramprasadagarwal ramprasadagarwal commented Jan 10, 2025 •
edited
Loading

What changes were proposed in this pull request?

  • When the files are queued for upload, currently we refresh the UI once all the files are uploaded, this becomes painful when the list of files that are queued is long.
  • To Give user the sense of upload success (Similar to file upload in Google Drive and other file browser), The short silent pooling is introduced, this refetches the list of files and folders in the background and updates the list with new files that got uploaded successfully.

How was this patch tested?

  • Manually tested

@ramprasadagarwal ramprasadagarwal self-assigned this Jan 10, 2025
@github-actions GitHub Actions
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

nidhibhatg
nidhibhatg approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@nidhibhatg nidhibhatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bjornalm
bjornalm reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you pooling or polling?

@ramprasadagarwal ramprasadagarwal changed the title [ui-storagebrowser] Adds silent pooling for list_dir during file upload [ui-storagebrowser] Adds silent polling for list_dir during file upload Jan 13, 2025
@ramprasadagarwal
Copy link
Collaborator Author

are you pooling or polling?

Its polling, It was a typo.

@bjornalm
Copy link
Collaborator

are you pooling or polling?

Its polling, It was a typo.

Makes sense, we need to update the code as well, since it says "pooling" in most places

@github-actions GitHub Actions
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

bjornalm
bjornalm approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramprasadagarwal ramprasadagarwal merged commit d2c8ce0 into master Jan 14, 2025
6 checks passed
@ramprasadagarwal ramprasadagarwal deleted the feat/storage-browser-14 branch January 14, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidhibhatg nidhibhatg nidhibhatg approved these changes

@bjornalm bjornalm bjornalm approved these changes

@JohanAhlen JohanAhlen Awaiting requested review from JohanAhlen

Assignees

@ramprasadagarwal ramprasadagarwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramprasadagarwal @bjornalm @nidhibhatg