Ensure response body is always closed in CloudControllerConnection

cloudfoundry · Jun 14, 2023 · 96c9db4 · 96c9db4
1 parent a500264
commit 96c9db4
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/api/cloudcontroller/cloud_controller_connection.go b/api/cloudcontroller/cloud_controller_connection.go
@@ -64,7 +64,6 @@ func (*CloudControllerConnection) handleStatusCodes(response *http.Response, pas
 		passedResponse.RawResponse = []byte("{}")
 	} else {
 		rawBytes, err := ioutil.ReadAll(response.Body)
-		defer response.Body.Close()
 		if err != nil {
 			return err
 		}
@@ -105,6 +104,7 @@ func (*CloudControllerConnection) handleWarnings(response *http.Response) ([]str
 
 func (connection *CloudControllerConnection) populateResponse(response *http.Response, passedResponse *Response) error {
 	passedResponse.HTTPResponse = response
+	defer response.Body.Close()
 
 	warnings, err := connection.handleWarnings(response)
 	if err != nil {