Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting issues #2938

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix linting issues #2938

merged 2 commits into from
May 24, 2024

Conversation

joaopapereira
Copy link
Contributor

Description of the Change

Fix linter issues and add a new gituhb action to run the linter on every PR

@joaopapereira joaopapereira force-pushed the fix-linter branch 5 times, most recently from 3a870b9 to 4becf7f Compare May 21, 2024 21:08
- Add new action that will be responsible for running the linter
- Fix all the linter issues
- Remove deprecated linters

Signed-off-by: João Pereira <joaod@vmware.com>
Copy link
Contributor

@Samze Samze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go fmt ./...
Running linters...
golangci-lint run --exclude-dirs cf --exclude-dirs fixtures --exclude-dirs plugin --exclude-dirs command/plugin
No lint errors!

🚀

Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gururajsh gururajsh merged commit a2a685b into cloudfoundry:main May 24, 2024
13 checks passed
@joaopapereira joaopapereira deleted the fix-linter branch August 22, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants