Improve reliability of the ssh units #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After multiple consecutive re-runs, the SSH suit looks ok. Recently there was one unrelated failure here. |
|
Related runs are filtered here |
|
Looks promising: Both got tcp timeouts in SSH suit - both recovered.
I'm wondering if nine attempts is a bit excessive, but IMO that's a good start. |
|
Looks pretty stable to me |
a-b
force-pushed
the
187325694-flaky-ssh-units-on-mac
branch
from
8d3bdea to
21b5840
Compare
- Simplified CLI SSH Suit execution to run togetheer with other non-plugin tests https://onsi.github.io/ginkgo/#repeating-spec-runs-and-managing-flaky-specs
a-b
force-pushed
the
187325694-flaky-ssh-units-on-mac
branch
from
21b5840 to
a59d826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Utilize Ginkgo v2 granular
FlakeAttempts()to improve reliability of util/clissh/ssh_test.go on mac workers.Why Is This PR Valuable?
Less false negative tests.
Backport