Remove Content-Type header while downloading droplets [main] #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopapereira
requested changes
Jun 24, 2024
moleske
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
this looks good, though same question as @joaopapereira , especially as it doesn't seem related to the rest of the commit
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Downloading a droplet from an S3 compatible storage using the command
cf download-dropletandcf curlfails whenContent-Typeheader is set in the request. So, removing it the header for this command.Why Is This PR Valuable?
Allows users to download droplet from S3 compatible storage.
Applicable Issues
NA
How Urgent Is The Change?
NA
Other Relevant Parties
NA