Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit go version #2999

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

Samze
Copy link
Contributor

@Samze Samze commented Jul 8, 2024

Description of the Change

Without this on arm64:

make test
go install github.com/onsi/ginkgo/v2/ginkgo
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available
make: *** [install-test-deps] Error 1

Since Go 1.21, x.y.z version is preferred for non-dev releases. See comment here golang/go#62278 (comment) and golang/go#62278 (comment)

Since go 1.21 there should be a specific version
See comment here golang/go#62278 (comment) and
golang/go#62278 (comment)
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samze Samze force-pushed the add_toolchain_version branch from 4829baa to 138ae13 Compare July 8, 2024 18:20
Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the tests are green we can merge

@gururajsh gururajsh merged commit 52b12d9 into cloudfoundry:main Jul 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants