Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all RunLumiEventAnalyzer instances to use vector<unsigned long long> #47085

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

makortel
Copy link
Contributor

PR description:

Following up #47032 (comment) this PR modernizes all uses of RunLumiEventAnalyzer, and removes the existsAs() call.

Resolves cms-sw/framework-team#1155

PR validation:

Framework unit tests run

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • FWCore/Framework (core)
  • FWCore/Integration (core)
  • IOPool/Common (core)
  • IOPool/Input (core)
  • IOPool/Streamer (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 64KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9417ef/43725/summary.html
COMMIT: 1f91374
CMSSW: CMSSW_15_0_X_2025-01-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47085/43725/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor Author

Comparison differences are related to #39803 and #47071

@makortel
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1cea75c into cms-sw:master Jan 13, 2025
11 checks passed
@makortel makortel deleted the runLumiEventAnalyzer branch January 13, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all RunLumiEventAnalyzer instances to use vector<unsigned long long>
3 participants