Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create service discovery.md #2163

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

akshayamadhuri
Copy link
Contributor

@akshayamadhuri akshayamadhuri commented Jun 20, 2023

Describe your changes

###2058

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: AKSHAYA MADHURI <76612327+akshayamadhuri@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit f43b8c7
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/656831441d2003000832b444
😎 Deploy Preview https://deploy-preview-2163--cncfglossary.netlify.app/hi/service-discovery
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jihoon-seo jihoon-seo linked an issue Jun 20, 2023 that may be closed by this pull request
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from my side

content/hi/service discovery.md Outdated Show resolved Hide resolved
content/hi/service discovery.md Outdated Show resolved Hide resolved
content/hi/service discovery.md Outdated Show resolved Hide resolved
content/hi/service discovery.md Outdated Show resolved Hide resolved
Signed-off-by: AKSHAYA MADHURI <76612327+akshayamadhuri@users.noreply.github.com>
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍

@aj11anuj aj11anuj added the Awaiting/2nd-approval This PR needs another approval review label Nov 12, 2023

'सर्विस डिस्कवरी' एक सेवा बनाने वाले व्यक्तिगत उदाहरणों को खोजने की प्रक्रिया है। एक सर्विस डिस्कवरी टूल, सर्विस बनाने वाले विभिन नोड्स या एंड-पॉइंट्स को ट्रैक करता है।

## समस्या यह संबोधित करती है
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## समस्या यह संबोधित करती है
## समस्या


क्लाउड नेटिव आर्किटेक्चर गतिशील और तरल हैं, जिसका अर्थ है कि वे लगातार बदलते रहेते हैं। एक कंटेनरीकृत ऐप संभवतः अपने जीवनकाल में कई बार शुरू और बंद होगा। हर बार ऐसा होने पर, इसका एक नया पता होगा और कोई भी ऐप जो इसे खोजना चाहता है उसे नए स्थान की जानकारी प्रदान करने के लिए एक टूल की आवश्यकता होगी।

## यह कैसे मदद करता है
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## यह कैसे मदद करता है
## समाधान

Signed-off-by: AKSHAYA MADHURI <76612327+akshayamadhuri@users.noreply.github.com>
Signed-off-by: AKSHAYA MADHURI <76612327+akshayamadhuri@users.noreply.github.com>
Signed-off-by: AKSHAYA MADHURI <76612327+akshayamadhuri@users.noreply.github.com>
Signed-off-by: Bishal Das  <70086051+bishal7679@users.noreply.github.com>
Copy link
Collaborator

@bishal7679 bishal7679 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @akshayamadhuri

@bishal7679 bishal7679 changed the base branch from main to dev-hi November 30, 2023 06:55
@bishal7679 bishal7679 merged commit 6c6f1f3 into cncf:dev-hi Nov 30, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting/2nd-approval This PR needs another approval review lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hi] Localize Service Discovery in Hindi.
3 participants