Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create zero-trust-architecture.md #2400

Closed
wants to merge 14 commits into from
Closed

Create zero-trust-architecture.md #2400

wants to merge 14 commits into from

Conversation

Aryan-Singla
Copy link
Contributor

@Aryan-Singla Aryan-Singla commented Sep 15, 2023 •
edited
Loading

Describe your changes

Zero-trust-architecture.md file for /hi localization

Related issue number or link

(resolves #2326)
(#2326)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@Aryan-Singla
Create zero-trust-architecture.md
30f4abe 
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Sep 15, 2023 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 6dede96
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/654c91b0a1c244000872da03
😎 Deploy Preview https://deploy-preview-2400--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/hi for Hindi label Sep 15, 2023
@Aryan-Singla
Copy link
Contributor Author

Reviewers Please look on this PR

aj11anuj
aj11anuj requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from my side

content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
justankiit
justankiit reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Improve this PR, as suggested by @aj11anuj

@Aryan-Singla
Copy link
Contributor Author

Sure

@Aryan-Singla
Copy link
Contributor Author

I will improve

Aryan-Singla and others added 11 commits November 9, 2023 08:32
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
ef8c0cd 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
ab1a5c8 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
7009ac2 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
85428e3 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
7b21f95 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
c91ce8c 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
02250a4 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
20ae634 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
6a2bb25 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
bece334 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
7ea1361 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
Aryan-Singla
Aryan-Singla commented Nov 9, 2023
View reviewed changes
Copy link
Contributor Author

@Aryan-Singla Aryan-Singla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@Aryan-Singla
Copy link
Contributor Author

Please review this I have made the changes

aj11anuj
aj11anuj requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these minor suggestions, rest of the things looks good to me 👍

content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
content/hi/content/en/zero-trust-architecture.md Outdated Show resolved Hide resolved
Aryan-Singla and others added 2 commits November 9, 2023 13:30
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
76a1278 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
@Aryan-Singla @aj11anuj
Update content/hi/content/en/zero-trust-architecture.md
6dede96 
Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
Aryan-Singla
Aryan-Singla commented Nov 9, 2023
View reviewed changes
Copy link
Contributor Author

@Aryan-Singla Aryan-Singla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@Aryan-Singla
Copy link
Contributor Author

Please review this I have made the changes

justankiit

This comment was marked as duplicate.

Sign in to view

aj11anuj
aj11anuj approved these changes Nov 12, 2023
View reviewed changes
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@aj11anuj aj11anuj added the Awaiting/2nd-approval This PR needs another approval review label Nov 12, 2023
justankiit
justankiit reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now!

justankiit
justankiit approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Aryan-Singla
Copy link
Contributor Author

@kumarankit999 how i can contact to you

@aj11anuj
Copy link
Collaborator

@ARYANis0001, your PR is ready to get merged but you have to change target branch from 'cncf: main' to 'cncf: dev-hi'

@aj11anuj aj11anuj removed the Awaiting/2nd-approval This PR needs another approval review label Nov 14, 2023
@Aryan-Singla
Copy link
Contributor Author

ok wait

@Aryan-Singla Aryan-Singla reopened this Nov 15, 2023
@Aryan-Singla Aryan-Singla changed the base branch from main to dev-hi November 15, 2023 01:28
@Aryan-Singla
Copy link
Contributor Author

@aj11anuj I have changed the branch to cncf dev-hi

@aj11anuj aj11anuj added the hold Wait, please do not proceed this yet label Nov 15, 2023
@github-actions GitHub Actions
Copy link

Wait, please do not proceed with this yet.

aj11anuj
aj11anuj reviewed Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed it, Location of this file "content/hi/content/en/zero-trust-architecture.md" doesn't exist. It should be "content/hi/zero-trust-architecture.md". And due to recent sync of dev-hi branch with main branch since a long time, some issues are arising like this one- "Zero-trust-architecture file already exists". So, now we cannot accept this one. Sorry for this inconvenience.

@aj11anuj aj11anuj closed this Nov 15, 2023
@Aryan-Singla Aryan-Singla deleted the patch-1 branch November 15, 2023 04:06
@Aryan-Singla
Copy link
Contributor Author

Ok ki will close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj11anuj aj11anuj aj11anuj approved these changes

@Garima-Negi Garima-Negi Awaiting requested review from Garima-Negi Garima-Negi is a code owner

@sayantani11 sayantani11 Awaiting requested review from sayantani11

@anubha-v-ardhan anubha-v-ardhan Awaiting requested review from anubha-v-ardhan

@jayesh-srivastava jayesh-srivastava Awaiting requested review from jayesh-srivastava jayesh-srivastava is a code owner

@abhay-raj19 abhay-raj19 Awaiting requested review from abhay-raj19 abhay-raj19 is a code owner

@bishal7679 bishal7679 Awaiting requested review from bishal7679 bishal7679 is a code owner

@justankiit justankiit Awaiting requested review from justankiit

Assignees
No one assigned
Labels
hold Wait, please do not proceed this yet lang/hi for Hindi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hi] Create zero-trust-architecture.md
3 participants
@Aryan-Singla @aj11anuj @justankiit