Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create transport-layer-security.md #2593

Merged
merged 9 commits into from
Mar 19, 2024
Merged

Conversation

Aryan-Singla
Copy link
Contributor

Describe your changes

Localize Transport Layer Security for Hindi

Related issue number or link (ex: resolves #issue-number)

resolves #2579

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: ARYAN <124805747+ARYANis0001@users.noreply.github.com>
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 948d026
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65df1d2eddb1a00008d92c39
😎 Deploy Preview https://deploy-preview-2593--cncfglossary.netlify.app/hi/transport-layer-security
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/hi for Hindi label Nov 9, 2023
@jihoon-seo jihoon-seo linked an issue Nov 13, 2023 that may be closed by this pull request
justankiit

This comment was marked as off-topic.

@seokho-son seokho-son added the hold Wait, please do not proceed this yet label Nov 17, 2023
Copy link

Wait, please do not proceed with this yet.

@seokho-son
Copy link
Collaborator

@ARYANis0001 I have a common comment on your PRs.
PTAL: #2605 (comment)

@seokho-son
Copy link
Collaborator

Hi @kumarankit999
I think the content of this PR is not visible in the preview, not approvable as is. (the reason why I don't mention how to fix is that @ARYANis0001 already had simmir request to fix in related PRs)
Anyway please try to check the Preview as well when you review PR. :)

@justankiit
Copy link
Contributor

Ok @seokho-son , I will keep in my mind!

@Aryan-Singla
Copy link
Contributor Author

Ok @seokho-son , I will keep in my mind!

Hey @seokho-son
Hey @kumarankit999
I want to express my sincere apologies for any inconvenience caused to the team members of CNCF/Glossary due to my raised PRs. I fully understand my mistake and acknowledge that I need to be more careful in the future. Going forward, I will ensure to thoroughly read the contributing guidelines and submit PRs in my native language, which I am fluent in and proficient in.

@Aryan-Singla
Copy link
Contributor Author

@ARYANis0001 I have a common comment on your PRs.
PTAL: #2605 (comment)

Hey @seokho-son
Hey @kumarankit999
I want to express my sincere apologies for any inconvenience caused to the team members of CNCF/Glossary due to my raised PRs. I fully understand my mistake and acknowledge that I need to be more careful in the future. Going forward, I will ensure to thoroughly read the contributing guidelines and submit PRs in my native language, which I am fluent in and proficient in.

@seokho-son
Copy link
Collaborator

Hello dev-hi team ! :)

#2605 (comment)

I think @ARYANis0001 closed other PRs except PRs for Hindi localization. I guess @ARYANis0001 is now focusing on Hindi localization only. Please guide @ARYANis0001

@Aryan-Singla
Copy link
Contributor Author

Aryan-Singla commented Nov 20, 2023

@seokho-son
Yes I will now only contribute to Hindi localization because Hindi is my native language and I am very proficient and fluent in Hindi

@justankiit
Copy link
Contributor

Yes @seokho-son now @ARYANis0001 has understood and will be able to do amazing contributions here!!

updated

Signed-off-by: ARYAN <devendergupta4573@gmail.com>
@Aryan-Singla
Copy link
Contributor Author

Hey @aj11anuj @kumarankit999 @bishal7679
I have added some words to simplify it can you please review it

@Aryan-Singla
Copy link
Contributor Author

Hey @aj11anuj @kumarankit999 please review it

Signed-off-by: ARYAN <devendergupta4573@gmail.com>
@Aryan-Singla
Copy link
Contributor Author

Hey @Garima-Negi Can you please review it

Signed off by: Aryan-Singla [devendergupta4573@gmail.com]

Signed-off-by: ARYAN <devendergupta4573@gmail.com>
Signed off by: Aryan-Singla [devendergupta4573@gmail.com]

Signed-off-by: ARYAN <devendergupta4573@gmail.com>
Signed off by: Aryan-Singla [devendergupta4573@gmail.com]

Signed-off-by: ARYAN <devendergupta4573@gmail.com>
Signed off: Aryan-Singla [devendergupta4573@gmail.com]

Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>
Signed-off-by: ARYAN <devendergupta4573@gmail.com>
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice now!

Signed off by: Aryan-Singla [devendergupta4573@gmail.com]

Signed-off-by: ARYAN <devendergupta4573@gmail.com>
@Aryan-Singla
Copy link
Contributor Author

Hello @aj11anuj if you have bandwidth then Please check this localization is there any need for improvement

@aj11anuj aj11anuj removed the hold Wait, please do not proceed this yet label Feb 28, 2024
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

content/hi/transport-layer-security.md Outdated Show resolved Hide resolved
content/hi/transport-layer-security.md Outdated Show resolved Hide resolved
content/hi/transport-layer-security.md Outdated Show resolved Hide resolved
content/hi/transport-layer-security.md Outdated Show resolved Hide resolved
content/hi/transport-layer-security.md Outdated Show resolved Hide resolved
content/hi/transport-layer-security.md Outdated Show resolved Hide resolved
content/hi/transport-layer-security.md Outdated Show resolved Hide resolved
Signed-off-by: Anuj Tiwari <aj11anuj123@gmail.com>
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@aj11anuj aj11anuj added the Awaiting/2nd-approval This PR needs another approval review label Feb 28, 2024
@aj11anuj
Copy link
Collaborator

@kumarankit999

Copy link
Collaborator

@abhay-raj19 abhay-raj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me 🚀

@abhay-raj19 abhay-raj19 merged commit 4dbc4c9 into cncf:dev-hi Mar 19, 2024
6 checks passed
@abhay-raj19
Copy link
Collaborator

Thanks For contributing ..Looking forward for more such !!🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting/2nd-approval This PR needs another approval review lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hi] Localize Transport Layer Security for Hindi
5 participants