Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move client generation to CLI methods #49

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Conversation

SchoolGuy
Copy link
Member

@SchoolGuy SchoolGuy commented Jun 16, 2024

This is needed so when executing --help or generating the shell completion no login is attempted to be performed.

Fixes #42

Building the project can be now done without the exit status 1:

enno@dell-laptop ~/S/G/cobbler-cli (main)> make build
building package
go build -o cobbler main.go
creating shell completions
make shell_completions
make[1]: Verzeichnis „/home/enno/Sources/GolandProjects/cobbler-cli“ wird betreten
./cobbler completion bash > config/completions/bash/cobbler
./cobbler completion fish > config/completions/fish/cobbler
./cobbler completion powershell > config/completions/powershell/cobbler
./cobbler completion zsh > config/completions/zsh/cobbler
make[1]: Verzeichnis „/home/enno/Sources/GolandProjects/cobbler-cli“ wird verlassen

@SchoolGuy SchoolGuy added this to the V0.0.1 milestone Jun 16, 2024
@SchoolGuy SchoolGuy requested a review from a team June 16, 2024 09:41
@SchoolGuy SchoolGuy force-pushed the fix/login-requests branch from a36d50a to e97aa3b Compare June 16, 2024 09:43
cmd/report.go Show resolved Hide resolved
This is needed so when executing --help or generating the shell completion no login is attempted to be performed.
@SchoolGuy SchoolGuy force-pushed the fix/login-requests branch from e97aa3b to 304b62a Compare June 16, 2024 09:57
Copy link

@tiltingpenguin tiltingpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy SchoolGuy merged commit 6ba1770 into main Jun 16, 2024
14 of 16 checks passed
@SchoolGuy SchoolGuy deleted the fix/login-requests branch June 16, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix login requests
2 participants