-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Carousel #54
base: master
Are you sure you want to change the base?
Project Carousel #54
Conversation
|
||
.checkProjects{ | ||
margin-top: 10px; | ||
color: gray; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Color gray
should be written in hexadecimal form as #808080
Color literals like gray
should only be used in variable declarations; they should be referred to via variable everywhere else.
@@ -36,3 +36,8 @@ | |||
color: #000000; | |||
font-size: large; | |||
} | |||
|
|||
.checkProjects{ | |||
margin-top: 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered color, margin-top
@@ -36,3 +36,8 @@ | |||
color: #000000; | |||
font-size: large; | |||
} | |||
|
|||
.checkProjects{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opening curly brace {
should be preceded by one space
Selector checkProjects
should be written in lowercase with hyphens
width: 220px; | ||
} | ||
.slick-slider { | ||
width: 85%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered margin, width
Fixes #52
Proposed Changes
Issues
There are few CSS adjustments in the cards and the buttons of the carousal
Followed the following tutorial :- https://www.freakyjolly.com/angular-slick-carousel-tutorial-with-custom-navigation/#.Xr9_mE8zbZI