Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Carousel #54

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

janethavi
Copy link
Contributor

@janethavi janethavi commented May 16, 2020

Fixes #52

Proposed Changes

  • Added a new carousel for projects

Issues

There are few CSS adjustments in the cards and the buttons of the carousal
Followed the following tutorial :- https://www.freakyjolly.com/angular-slick-carousel-tutorial-with-custom-navigation/#.Xr9_mE8zbZI

@janethavi janethavi added the help wanted Extra attention is needed label May 16, 2020

.checkProjects{
margin-top: 10px;
color: gray;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color gray should be written in hexadecimal form as #808080
Color literals like gray should only be used in variable declarations; they should be referred to via variable everywhere else.

@@ -36,3 +36,8 @@
color: #000000;
font-size: large;
}

.checkProjects{
margin-top: 10px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered color, margin-top

@@ -36,3 +36,8 @@
color: #000000;
font-size: large;
}

.checkProjects{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening curly brace { should be preceded by one space
Selector checkProjects should be written in lowercase with hyphens

width: 220px;
}
.slick-slider {
width: 85%;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered margin, width

@janethavi janethavi changed the title Project Project Carousel May 16, 2020
@hasalfernando hasalfernando added the hacktoberfest Issues related to hacktoberfest label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues related to hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement to Our Work section
2 participants