-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Move from Alpha to Beta #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is fairly significant changes being made, mostly related with updating their plugin attributes, changing attributes, deleting certain files and changing the status of the plugins from alpha to beta. This implies that these plugins are ready for the second phase of software testing, where testers outside organization can check the functionality.
@@ -1,22 +1,10 @@ | |||
{ | |||
"mode": "pre", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line indicates that all the plugins under consideration were previously in the alpha phase of testing and are now transitioned to the beta phase. Ensure that all bugs encountered and issues faced during alpha phase of testing are resolved before proceeding to further stages.
@@ -1,22 +1,10 @@ | |||
{ | |||
"mode": "pre", | |||
"tag": "alpha", | |||
"tag": "beta", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this line numbers the version of the plugins has been downgraded to '0.0.0'. Before the changes, all the plugins were on version '0.0.1'. This seems like an error. Make sure to correct the versions.
@@ -7,7 +7,7 @@ | |||
# Codecov Bundler Plugins | |||
|
|||
> [!WARNING] | |||
> These plugins are currently in alpha and are subject to change. | |||
> These plugins are currently in beta and are subject to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In these lines, it is mentioned the status of these plugins have changed from alpha to beta but note that the plugins are still subject to change. This indicates that while the plugins are more stable than during the alpha phase, they are not yet in their final versions and more changes are expected.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/bundler-plugin-core", | |||
"version": "0.0.1-alpha.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number here is also changed back to '0.0.0'. The version numbering should make sense and should not be decreased.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/vite-plugin", | |||
"version": "0.0.1-alpha.3", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In these lines, the versions of the plugins are also reverted to '0.0.0'. It's unusual to see versions being downgraded. Please verify the versions
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/webpack-plugin", | |||
"version": "0.0.1-alpha.3", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versions of the plugins are reverted back to '0.0.0'. Please validate and rectify the version.
"@codecov/webpack-plugin": patch | ||
--- | ||
|
||
Rename uploaderOverrides to uploadOverrides, remove url from uploadOverrides, and removal of repoToken/globalUploadToken in favour of just uploadToken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On this line, uploaderOverrides is being renamed to uploadOverrides, and the url is being removed from uploadOverrides. The repoToken/globalUploadToken are also being removed in favor of just uploadToken. All these changes seem significant and a complete understanding of these tokens and their implications is necessary before these widespread changes are committed.
"@codecov/bundler-plugin-core": patch | ||
--- | ||
|
||
Adjust peer dep versions to use x-range instead of caret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, it's noticed that it's now preferred to use x-range instead of caret for the peer dependencies. A thorough understanding of these operators in the context of the project version control is advisable.
"@codecov/vite-plugin": patch | ||
--- | ||
|
||
Add missing outputPath to output stats file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this line alike others too, an OutputPath has been added to release the output stats file. Check if this does not lead to any complications or errors while running the program.
@@ -1,5 +1,31 @@ | |||
# @codecov/webpack-plugin | |||
|
|||
## 0.0.1-beta.0 | |||
|
|||
### Patch Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this line, we're adding duration to webpack bundler plugin directly. Please make sure these changes don't impact the performance and is deemed necessary.
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Description
This PR does a few hacky things to get changeset to play nicely to move us into a beta pre-release from the current alpha pre-release.