-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update package versions (beta) #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code update involves version bumping and corresponding updates in the changelogs spanning multiple packages within the Codecov repository. It suggests the transition from alpha to beta versions for these packages is what mandated these changes. I don't see any significant issues with the changes made. They are quite straightforward and, thus, do not demand extensive review.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/bundler-plugin-core", | |||
"version": "0.0.0", | |||
"version": "0.0.1-beta.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always good to keep your package.json updated with the correct versions. Keep in mind that maintaining consistency across packages may prevent version mismatch issues. Nice update.
@@ -4,6 +4,12 @@ | |||
|
|||
### Patch Changes | |||
|
|||
- f5cae1c: Move packages into beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintaining accurate and detailed changelog records is very good practice. It provides clear insights into what changes were made with each commit. Great job at explaining the changes.
@@ -6,5 +6,6 @@ | |||
"@codecov/rollup-plugin": "0.0.0", | |||
"@codecov/vite-plugin": "0.0.0", | |||
"@codecov/webpack-plugin": "0.0.0" | |||
} | |||
}, | |||
"changesets": ["healthy-foxes-joke"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the changeset 'healthy-foxes-joke' refers to the correct set of changes, as the identification seems quite generic. It might be helpful to give changesets more informative names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 2773363
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/bundler-plugin-core", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on the transition of '@codecov/bundler-plugin-core' to the beta stage. Ensure other relevant systems/utils are made aware of this version change.
@@ -4,6 +4,9 @@ | |||
|
|||
### Patch Changes | |||
|
|||
- f5cae1c: Move packages into beta | |||
- Updated dependencies [f5cae1c] | |||
- @codecov/bundler-plugin-core@0.0.1-beta.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the updated dependency '@codecov/bundler-plugin-core' plays well with the '@codecov/rollup-plugin'. Make sure to test the interaction.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/rollup-plugin", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The '@codecov/rollup-plugin' transition to the beta stage should also be recognized by relevant utilities. Make sure that its users are informed about the version change.
@@ -4,6 +4,9 @@ | |||
|
|||
### Patch Changes | |||
|
|||
- f5cae1c: Move packages into beta | |||
- Updated dependencies [f5cae1c] | |||
- @codecov/bundler-plugin-core@0.0.1-beta.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, verify that the updated dependency '@codecov/bundler-plugin-core' does not have any conflicts with '@codecov/vite-plugin'. Running comprehensive tests would be a good step.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/vite-plugin", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above, '@codecov/vite-plugin's' transition to the beta stage should also be taken into account by relevant systems and its users.
@@ -4,6 +4,9 @@ | |||
|
|||
### Patch Changes | |||
|
|||
- f5cae1c: Move packages into beta | |||
- Updated dependencies [f5cae1c] | |||
- @codecov/bundler-plugin-core@0.0.1-beta.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check that the updated dependency '@codecov/bundler-plugin-core' is compatible with '@codecov/webpack-plugin'. Ensure the integration is tested.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/webpack-plugin", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, consider the '@codecov/webpack-plugin's' transition to the beta stage is well maintained and communicated across the relevant systems and users.
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will increase total bundle size by 55 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
main
is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, runchangeset pre exit
onmain
.Releases
@codecov/bundler-plugin-core@0.0.1-beta.0
Patch Changes
@codecov/rollup-plugin@0.0.1-beta.0
Patch Changes
@codecov/vite-plugin@0.0.1-beta.0
Patch Changes
@codecov/webpack-plugin@0.0.1-beta.0
Patch Changes