-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Fortran documentation (1/2) #41
Conversation
c380e3f
to
70d218e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, LGTM!
Checks/PWR043/README.md
Outdated
Have a look at the following code: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unnecessary, I would just remove this sentence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it doesn't add any value. For the sake of brevity, I've removed the sentence from all entries where it is repeated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
70d218e
to
53da9a7
Compare
53da9a7
to
1ad58ea
Compare
Currently, approximately half of the Open Catalog's checks applicable to Fortran lack code examples in their respective
README.md
files.This PR addresses part of the issue by identifying all checks that already have standalone Fortran code examples (separate files like
example.f90
) but are not yet used in theREADME.md
entries. A follow-up PR will address the remaining checks with no Fortran code examples available.These new Fortran code explanations are mainly a copy-paste from the already existing descriptions for the C codes. Note that, in some checks, the
README.md
uses simplified C and Fortran code examples instead of the ones provided as standalone files.