PWR072: Suggest splitting the variable initialization #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvrogd
requested review from
jgonzac and
d-alonso
and removed request for
a team
inaki-amatria
approved these changes
Oct 28, 2024
jgonzac
approved these changes
Oct 28, 2024
Instead of adding an explicit `save` attribute. This update results from taking into account that, in most times, the `save` behavior is unintentional and thus a source of bugs, instead of something that programmers want to leverage in their codes. Note that the benchmark code has not been updated. If a code is incorrect due to the implicit `save` behavior, and the issue is resolved by splitting the initialization, it does not make sense to compare the performance of an incorrect code vs. a correct one. In contrast, there's still value in benchmarking the particular scenario where the `save` behavior is desired, comparing the performance of making it explicit vs. keeping it implicit.
alvrogd
force-pushed
the
feature/SwitchPWR072
branch
from
a8903d9 to
5158c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding an explicit
saveattribute.This update results from taking into account that, in most times, the
savebehavior is unintentional and thus a source of bugs, instead of something that programmers want to leverage in their codes.Note that the benchmark code has not been updated. If a code is incorrect due to the implicit
savebehavior, and the issue is resolved by splitting the initialization, it does not make sense to compare the performance of an incorrect code vs. a correct one. In contrast, there's still value in benchmarking the particular scenario where thesavebehavior is desired, comparing the performance of making it explicit vs. keeping it implicit.