Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWR007: Suggest using implicit none (external) #50

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

inaki-amatria
Copy link
Contributor

@inaki-amatria inaki-amatria commented Dec 2, 2024

Suggest using the extended form implicit none (type, external) to avoid calling procedures through implicit interfaces. I also took the chance to adjust the benchmark script actions to trigger iff we change source code. And I also formatted one line in PWR007 so it does not exceed 80 characters 😁.

@inaki-amatria inaki-amatria self-assigned this Dec 2, 2024
@inaki-amatria inaki-amatria force-pushed the feature/AddATipToPWR007 branch 3 times, most recently from c48d94e to c44f8c5 Compare December 2, 2024 13:02
Checks/PWR007/README.md Outdated Show resolved Hide resolved
.github/workflows/test-benchmark-script.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@daniel-otero daniel-otero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I also agree with @alvrogd suggestions.

@inaki-amatria inaki-amatria force-pushed the feature/AddATipToPWR007 branch from c44f8c5 to 83a239c Compare December 3, 2024 07:50
@inaki-amatria inaki-amatria merged commit 83a239c into main Dec 3, 2024
5 checks passed
@inaki-amatria inaki-amatria deleted the feature/AddATipToPWR007 branch December 3, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants