-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to test examples are compilable #53
Conversation
16fc2b8
to
a7f4bee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! This will be super-helpful :)
Just noticed that the output of the script you shared seems to be a little convoluted. For instance, the first failure occurs when compiling Could we solve this by only keeping the last status line for each file?; i.e., the ones with the |
This was easier than expected, I just used the |
0182eaa
to
a7432b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was easier than expected, I just used the CHECK_{START,PASS,FAIL} that CMake already provides. I think it's good to keep the two lines in case the try_compile call has a CMake error itself, you'll see which file was going to be compiled right above it (I know because it happened to me).
That's great! This approach looks good to me.
They contained some wrong directive clauses that either - Referenced not-yet-declared variables - Were missing the datascoping for a referenced variable
a7432b1
to
6ceccc3
Compare
And fix those codes that trip the new workflow
Example of a failing run: https://github.com/codee-com/open-catalog/actions/runs/12238572380/job/34136975245