Add Google Analytics, now GDPR-compliant #54
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvrogd
reviewed
Dec 10, 2024
There was a problem hiding this comment.
If I'm not mistaken, the banner should provide a link to the cookie policy (see Section 3.1.2.2, Page 21).
inaki-amatria
force-pushed
the
feature/AddGoogleAnalytics
branch
from
ac916a4 to
8ae8006
Compare
There was a problem hiding this comment.
I miss a link to the privacy policy and a way to:
Make it as easy for users to withdraw their consent as it was for them to give their consent in the first place.
Otherwise, looks great!
Comment on lines
37
to
38
| We only use cookies for analytics to enhance your experience and improve | ||
| our site. Is that okay with you? |
There was a problem hiding this comment.
Should we mention that is Google Analytics? Seems more transparent that way.
| > | ||
| <h3 style={{ color: 'var(--cookie-consent-banner-heading-color)' }}>🍪 We use cookies!</h3> | ||
| <p> | ||
| We only use cookies for analytics to enhance your experience and improve |
There was a problem hiding this comment.
Also, we use "Strictly necessary", not just for analytics (to store that the analytics response was "decline").
inaki-amatria
force-pushed
the
feature/AddGoogleAnalytics
branch
from
8ae8006 to
e33c52f
Compare
inaki-amatria
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces Google Analytics integration to the Open Catalog. To ensure compliance with privacy standards, a Cookie Consent Banner is displayed first, requesting the user's permission before tracking any data.