Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #1051

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

WIP #1051

wants to merge 4 commits into from

Conversation

analoo
Copy link
Contributor

@analoo analoo commented Jan 16, 2025

πŸ”— Jira ticket

✍️ Description

πŸ“· Design reference

βœ… Completion tasks

  • Added relevant tests
  • Meets acceptance criteria

@enyia21 enyia21 temporarily deployed to il-gcc-ccap-507-route-c-3d20gd January 16, 2025 23:31 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-507-route-c-3d20gd January 17, 2025 23:25 Inactive
}

public static Optional<CCRR> findCCRRByCaseLoadCode(String caseloadCode) {
Boolean caseloadPresent = CCRR_MAP.containsKey(caseloadCode);

Check warning

Code scanning / CodeQL

Boxed variable is never null Warning

The variable 'caseloadPresent' is only assigned values of primitive type and is never 'null', but it is declared with the boxed type 'Boolean'.
@@ -29,4 +50,9 @@
public String getHelpText() {
return null;
}

public static Optional<ZipcodeOption> getZipCodeFromCountyName(String countyName) {
Boolean hasCounty = COUNTY_MAP.containsKey(countyName);

Check warning

Code scanning / CodeQL

Boxed variable is never null Warning

The variable 'hasCounty' is only assigned values of primitive type and is never 'null', but it is declared with the boxed type 'Boolean'.
}

public static Optional<String> getOrganizationIdByZipCode(String zipcode) {
Boolean hasZip = ZIPCODE_MAP.containsKey(zipcode);

Check warning

Code scanning / CodeQL

Boxed variable is never null Warning

The variable 'hasZip' is only assigned values of primitive type and is never 'null', but it is declared with the boxed type 'Boolean'.
@analoo analoo added the Open to feedback This PR isn't ready to be merged into `main` but feedback is welcome label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Open to feedback This PR isn't ready to be merged into `main` but feedback is welcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants