Complete sign and submit 187003764 #43

vrajmohan · 2024-02-10T13:37:49Z

No description provided.

bseeger · 2024-02-12T15:36:45Z

Related to this PR. This line's fonts are smaller than the design. I'm wondering if you can try it as a subheader in the cardHeader font:

cardHeader(header=#{legal-stuff.header}, subheader=#{legal-stuff.help})

bseeger · 2024-02-12T15:38:09Z

Related to this PR:
The wording on the http://localhost:8080/flow/mdBenefitsFlow/sensitiveConvictionQuestionsIntro is different from the design. The apps page has more text than the design has.

bseeger · 2024-02-12T15:56:42Z

Also related to this PR:
In the "Your Right's" section on the rightsAndResponsibility page all the page links to external references are missing. The listed URLs are not <a href>s.

Under "TCA and SNAP Penalties" - the first line ("Do not:") should be bold.

bseeger · 2024-02-12T15:58:42Z

the rightsAndResponsibilites page is missing the "Medicaid Warning and Penalties" section.

bseeger · 2024-02-12T16:05:29Z

The first, second and signature page seems different from the design. Not sure what's changed. I know I listed things outside of this PR, but I thought this PR was completing this section and it looks like there is more work to be done. Separate ticket?

Add a checkboxFieldsetUnescaped fragment to achieve this.

1. We were accidentally copying smart quotes from Figma 2. Had to style <ul> explicitly as Honeycrisp was overriding the "natural" styles

- Make bold to mimic the PDF - Use subtext for form header help text - Format external links

We decided to include this in T&Cs even though we are not supporting Medicaid.

bseeger

I have one more comment about what agreement I should see when. If I choose TDAP only, I get an OHEP agreement (only). Wasn't sure if that was supposed to happen?

bseeger · 2024-02-15T17:25:04Z

src/main/resources/templates/mdBenefitsFlow/sensitiveConvictionQuestions.html

-                  label=#{${label}},
-                  content=~{::checkboxInSetContent})}">
-                  <th:block th:ref="checkboxInSetContent">
+              <div th:with="inputName='someone' + ${question}, label='sensitive-conviction-question-' + ${question}, helpText='sensitive-conviction-question-' + ${question} + '-helpText'">


Not related to this line, but putting here. I noticed that the questions for violating parole and trading/trafficking SNAP are reversed from what the design has. Not sure if that's significant or by design.

Good catch. Updating.

bseeger

Minor comments. Feel free to merge once addressed.

analoo · 2024-02-15T21:47:19Z

src/main/java/org/mdbenefits/app/submission/actions/SetDefaultSensitiveConvictionAnswers.java

@@ -16,6 +16,6 @@ public class SetDefaultSensitiveConvictionAnswers implements Action {

    @Override
    public void run(Submission submission) {
-        Arrays.stream(SubmissionUtilities.SENSITIVE_CONVICTION_QUESTIONS).forEach(s -> submission.getInputData().putIfAbsent("noOne" + s + "[]", "true"));
+        Arrays.stream(SubmissionUtilities.SENSITIVE_CONVICTION_QUESTIONS).forEach(s -> submission.getInputData().putIfAbsent("someone" + s, "false"));


I love this pattern.

analoo · 2024-02-15T21:53:08Z

src/test/java/org/mdbenefits/app/journeys/MdBenefitsFlowJourneyTest.java

@@ -394,10 +394,17 @@ void docUploadSkipTest() {
    @Test
    void sensitiveConvictionQuestionsArePreCheckedTest() {


Small thing:

sensitiveConvictionQuestionsArePrecheckedNoTest

Good catch, went with sensitiveConvictionQuestionsArePreCheckedToFalseTest

analoo · 2024-02-15T21:55:32Z

PR looked good to me. Only general feedback is a question around web addresses: Do we always link the actual page or is that something we only do if the design requires it. For example there are a few places in rights and responsibilities where I can see a URL but I don't have the ability to select it:

vrajmohan · 2024-02-15T22:11:39Z

@analoo , I missed a spot in formatting URLs. And thanks to that, I found another :-(

vrajmohan force-pushed the complete-sign-and-submit-187003764 branch 2 times, most recently from a6a8ea6 to 13b90f0 Compare February 11, 2024 15:27

bseeger self-requested a review February 12, 2024 15:13

vrajmohan force-pushed the complete-sign-and-submit-187003764 branch 6 times, most recently from 0201a07 to 9737a69 Compare February 14, 2024 23:40

vrajmohan added 5 commits February 14, 2024 16:29

Update message resources

d80d58c

Update and format the crime against women question

b6f1df4

Add a checkboxFieldsetUnescaped fragment to achieve this.

Style the terms and conditions fragments

81c7fc0

1. We were accidentally copying smart quotes from Figma 2. Had to style <ul> explicitly as Honeycrisp was overriding the "natural" styles

Update wording on Sensitive Questions Intro page

2faba9f

Switch to radio buttons and update wording

716444e

vrajmohan force-pushed the complete-sign-and-submit-187003764 branch 2 times, most recently from 23b7138 to bf88fb7 Compare February 15, 2024 04:02

vrajmohan added 4 commits February 15, 2024 06:17

Pass helpText to radioFieldsetUnescaped

f8dcd4c

Fix some style issues

6ca0330

- Make bold to mimic the PDF - Use subtext for form header help text - Format external links

Add Medicaid Warning and Penalties section

3c0f4e4

We decided to include this in T&Cs even though we are not supporting Medicaid.

Use radio buttons for sensitive questions in PDF

b2e332a

vrajmohan force-pushed the complete-sign-and-submit-187003764 branch from bf88fb7 to b2e332a Compare February 15, 2024 14:17

bseeger reviewed Feb 15, 2024

View reviewed changes

bseeger self-requested a review February 15, 2024 20:01

bseeger approved these changes Feb 15, 2024

View reviewed changes

analoo reviewed Feb 15, 2024

View reviewed changes

analoo approved these changes Feb 15, 2024

View reviewed changes

vrajmohan added 2 commits February 15, 2024 14:07

Update order of sensitive conviction questions

a249d1f

Update test name to reflect assertion

00dc20e

Format missing links in Rights and Responsibilities

8e92340

vrajmohan merged commit 9f6ca82 into main Feb 15, 2024
4 checks passed

vrajmohan deleted the complete-sign-and-submit-187003764 branch February 16, 2024 04:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Complete sign and submit 187003764 #43

Complete sign and submit 187003764 #43

vrajmohan commented Feb 10, 2024

bseeger commented Feb 12, 2024

bseeger commented Feb 12, 2024

bseeger commented Feb 12, 2024 •

edited

Loading

bseeger commented Feb 12, 2024

bseeger commented Feb 12, 2024

bseeger left a comment

bseeger Feb 15, 2024

vrajmohan Feb 15, 2024

bseeger left a comment

analoo Feb 15, 2024

analoo Feb 15, 2024

vrajmohan Feb 15, 2024

analoo commented Feb 15, 2024

vrajmohan commented Feb 15, 2024 •

edited

Loading

		@@ -394,10 +394,17 @@ void docUploadSkipTest() {
		@Test
		void sensitiveConvictionQuestionsArePreCheckedTest() {

Complete sign and submit 187003764 #43

Complete sign and submit 187003764 #43

Conversation

vrajmohan commented Feb 10, 2024

bseeger commented Feb 12, 2024

bseeger commented Feb 12, 2024

bseeger commented Feb 12, 2024 • edited Loading

bseeger commented Feb 12, 2024

bseeger commented Feb 12, 2024

bseeger left a comment

Choose a reason for hiding this comment

bseeger Feb 15, 2024

Choose a reason for hiding this comment

vrajmohan Feb 15, 2024

Choose a reason for hiding this comment

bseeger left a comment

Choose a reason for hiding this comment

analoo Feb 15, 2024

Choose a reason for hiding this comment

analoo Feb 15, 2024

Choose a reason for hiding this comment

vrajmohan Feb 15, 2024

Choose a reason for hiding this comment

analoo commented Feb 15, 2024

vrajmohan commented Feb 15, 2024 • edited Loading

bseeger commented Feb 12, 2024 •

edited

Loading

vrajmohan commented Feb 15, 2024 •

edited

Loading