Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable assignment order in CompileTools.ts #1653

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

worksofliam
Copy link
Contributor

Changes

Because BRANCH was before BRANCHLIB, I was getting the incorrect value in BRANCHLIB as &BRANCHLIB was evaluating to some/random/branchLIB

Checklist

  • have tested my change

@worksofliam
Copy link
Contributor Author

worksofliam commented Nov 15, 2023

Test:

  {
    "name": "Test branch name",
    "command": "echo '&BRANCH &BRANCHLIB'",
    "environment": "pase",
    "extensions": [
      "GLOBAL"
    ]
  }
 *  Executing task: IBM i: Test branch name 

Commands:
                echo 'main VS24334339'

main VS24334339

Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a few minutes to understand why the order was important 😅

@sebjulliand sebjulliand merged commit 2ae070e into master Nov 15, 2023
1 check passed
@sebjulliand sebjulliand deleted the fix/branchlib_vs_branch branch November 15, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants